Overview
Comment: | [fx] remember ignored errors |
---|---|
Downloads: | Tarball | ZIP archive | SQL archive |
Timelines: | family | ancestors | descendants | both | fx | kill_innerHTML |
Files: | files | file ages | folders |
SHA3-256: |
5a76e4a564b7c58be0e11fc89a69e149 |
User & Date: | olr on 2017-07-18 08:35:50 |
Other Links: | branch diff | manifest | tags |
Context
2017-07-18
| ||
09:31 | [fx] arrow for tooltips check-in: 018b49d9ba user: olr tags: fx, kill_innerHTML | |
08:35 | [fx] remember ignored errors check-in: 5a76e4a564 user: olr tags: fx, kill_innerHTML | |
07:56 | [fx][bug] useless html entities when using textContent check-in: 66c2ed43a6 user: olr tags: fx, kill_innerHTML | |
Changes
Modified gc_lang/fr/xpi/data/gc_panel.js from [2e8cdac4ec] to [2a10459ec0].
1 2 3 4 5 6 7 8 9 10 11 | // JavaScript let nPanelWidth = 0; // must be set at launch let bExpanded = true; /* Events */ showSpecialMessage(); | > > > > > > > > | 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 | // JavaScript let nPanelWidth = 0; // must be set at launch let bExpanded = true; /* Ignored errors idendified by <sIgnoredKey> sIgnoredKey: <iParagraph:nStart:nEnd:sUnderlined> */ let aIgnoredErrors = new Set(); /* Events */ showSpecialMessage(); |
︙ | ︙ | |||
53 54 55 56 57 58 59 60 61 62 63 64 65 66 | document.getElementById("message").textContent = sText; document.getElementById("messagebox").style.display = "block"; window.setTimeout(closeMessageBox, 20000); }); self.port.on("clearErrors", function (sHtml) { document.getElementById("errorlist").textContent = ""; hideAllTooltips(); }); self.port.on("start", function() { startWaitIcon(); }); | > | 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 | document.getElementById("message").textContent = sText; document.getElementById("messagebox").style.display = "block"; window.setTimeout(closeMessageBox, 20000); }); self.port.on("clearErrors", function (sHtml) { document.getElementById("errorlist").textContent = ""; aIgnoredErrors.clear(); hideAllTooltips(); }); self.port.on("start", function() { startWaitIcon(); }); |
︙ | ︙ | |||
205 206 207 208 209 210 211 | let nErr = 0; // we count errors to give them an identifier let nEndLastErr = 0; for (let oErr of aGrammErr) { let nStart = oErr["nStart"]; let nEnd = oErr["nEnd"]; if (nStart >= nEndLastErr) { | | > | < | > > | 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 | let nErr = 0; // we count errors to give them an identifier let nEndLastErr = 0; for (let oErr of aGrammErr) { let nStart = oErr["nStart"]; let nEnd = oErr["nEnd"]; if (nStart >= nEndLastErr) { oErr['sErrorId'] = iParagraph.toString() + "_" + nErr.toString(); // error identifier oErr['sIgnoredKey'] = iParagraph.toString() + ":" + nStart.toString() + ":" + nEnd.toString() + ":" + sParagraph.slice(nStart, nEnd); if (nEndLastErr < nStart) { xParagraph.appendChild(document.createTextNode(sParagraph.slice(nEndLastErr, nStart))); } xParagraph.appendChild(_createError(sParagraph.slice(nStart, nEnd), oErr)); xParagraph.insertAdjacentHTML("beforeend", "<!-- err_end -->"); nEndLastErr = nEnd; } nErr += 1; } if (nEndLastErr <= sParagraph.length) { xParagraph.appendChild(document.createTextNode(sParagraph.slice(nEndLastErr))); } } catch (e) { showError(e); } } function _createError (sUnderlined, oErr) { let xNodeErr = document.createElement("u"); xNodeErr.id = "err" + oErr['sErrorId']; xNodeErr.textContent = sUnderlined; xNodeErr.dataset.error_id = oErr['sErrorId']; xNodeErr.dataset.ignored_key = oErr['sIgnoredKey']; xNodeErr.dataset.error_type = (oErr['sType'] === "WORD") ? "spelling" : "grammar"; xNodeErr.setAttribute("href", "#"); xNodeErr.setAttribute("onclick", "return false;"); if (xNodeErr.dataset.error_type === "grammar") { xNodeErr.dataset.gc_message = oErr['sMessage']; xNodeErr.dataset.gc_url = oErr['URL']; if (xNodeErr.dataset.gc_message.includes(" #")) { xNodeErr.dataset.line_id = oErr['sLineId']; xNodeErr.dataset.rule_id = oErr['sRuleId']; } xNodeErr.dataset.suggestions = oErr["aSuggestions"].join("|"); } xNodeErr.className = (aIgnoredErrors.has(xNodeErr.dataset.ignored_key)) ? "ignored" : "error " + oErr['sType']; return xNodeErr; } function applySuggestion (sSuggId) { // sugg try { let sErrorId = document.getElementById(sSuggId).dataset.error_id; let sIdParagr = sErrorId.slice(0, sErrorId.indexOf("_")); |
︙ | ︙ | |||
265 266 267 268 269 270 271 | catch (e) { showError(e); } } function ignoreError (sIgnoreButtonId) { // ignore try { | | > | | | | | | | | | | | | | | | | 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 | catch (e) { showError(e); } } function ignoreError (sIgnoreButtonId) { // ignore try { //console.log("ignore button: " + sIgnoreButtonId + " // error id: " + document.getElementById(sIgnoreButtonId).dataset.error_id); let xNodeErr = document.getElementById("err"+document.getElementById(sIgnoreButtonId).dataset.error_id); aIgnoredErrors.add(xNodeErr.dataset.ignored_key); xNodeErr.className = "ignored"; xNodeErr.removeAttribute("style"); hideAllTooltips(); } catch (e) { showError(e); } } function showTooltip (sNodeErrorId) { // err try { hideAllTooltips(); let xNodeErr = document.getElementById(sNodeErrorId); let sTooltipId = (xNodeErr.dataset.error_type === "grammar") ? "gc_tooltip" : "sc_tooltip"; let xNodeTooltip = document.getElementById(sTooltipId); let nLimit = nPanelWidth - 330; // paragraph width - tooltip width xNodeTooltip.style.top = (xNodeErr.offsetTop + 16) + "px"; xNodeTooltip.style.left = (xNodeErr.offsetLeft > nLimit) ? nLimit + "px" : xNodeErr.offsetLeft + "px"; if (xNodeErr.dataset.error_type === "grammar") { // grammar error document.getElementById("gc_message").textContent = xNodeErr.dataset.gc_message; if (xNodeErr.dataset.gc_url != "") { document.getElementById("gc_url").style.display = "inline"; document.getElementById("gc_url").setAttribute("href", xNodeErr.dataset.gc_url); } else { document.getElementById("gc_url").style.display = "none"; } document.getElementById("gc_ignore").dataset.error_id = xNodeErr.dataset.error_id; let iSugg = 0; let xGCSugg = document.getElementById("gc_sugg_block"); xGCSugg.textContent = ""; for (let sSugg of xNodeErr.dataset.suggestions.split("|")) { xGCSugg.appendChild(_createSuggestion(xNodeErr.dataset.error_id, iSugg, sSugg)); xGCSugg.appendChild(document.createTextNode(" ")); iSugg += 1; } } xNodeTooltip.style.display = "block"; if (xNodeErr.dataset.error_type === "spelling") { // spelling mistake document.getElementById("sc_ignore").dataset.error_id = xNodeErr.dataset.error_id; //console.log("getSuggFor: " + xNodeErr.textContent.trim() + " // error_id: " + xNodeErr.dataset.error_id); self.port.emit("getSuggestionsForTo", xNodeErr.textContent.trim(), xNodeErr.dataset.error_id); } } catch (e) { showError(e); } } |
︙ | ︙ |