Overview
Comment: | [build][fx][bug] lexicon editor: set dictionary after import, hide save button after saving, + workaround for building with permanent specific profile (web-ext bug) |
---|---|
Downloads: | Tarball | ZIP archive | SQL archive |
Timelines: | family | ancestors | descendants | both | trunk | build | fx |
Files: | files | file ages | folders |
SHA3-256: |
63cbaf723696a5146d47c19c505688fc |
User & Date: | olr on 2018-04-06 12:36:08 |
Original Comment: | [fx][bug] lexicon editor: set dictionary after import, hide save button after saving |
Other Links: | manifest | tags |
Context
2018-04-06
| ||
12:39 | [build][fx] revert: build with specific permanent profile check-in: 5432f40daf user: olr tags: trunk, build, fx | |
12:36 | [build][fx][bug] lexicon editor: set dictionary after import, hide save button after saving, + workaround for building with permanent specific profile (web-ext bug) check-in: 63cbaf7236 user: olr tags: trunk, build, fx | |
12:02 | [fx][bug] fix personal dictionary loading at startup check-in: 1a70959cda user: olr tags: trunk, fr | |
Changes
Modified gc_lang/fr/webext/panel/lex_editor.js from [9a4c845c84] to [6d5b05bd83].
︙ | ︙ | |||
197 198 199 200 201 202 203 204 205 206 207 208 209 210 | deleteRow (iEntry) { this.lEntry[parseInt(iEntry)] = null; if (document.getElementById(this.sNodeId + "_row_" + iEntry)) { document.getElementById(this.sNodeId + "_row_" + iEntry).style.display = "none"; } this.nEntry -= 1; this.showEntryNumber(); } getEntries () { return this.lEntry.filter((e) => e !== null); } } | > > > | 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 | deleteRow (iEntry) { this.lEntry[parseInt(iEntry)] = null; if (document.getElementById(this.sNodeId + "_row_" + iEntry)) { document.getElementById(this.sNodeId + "_row_" + iEntry).style.display = "none"; } this.nEntry -= 1; this.showEntryNumber(); if (this.sNodeId == "lexicon_table") { showElement("save_button"); } } getEntries () { return this.lEntry.filter((e) => e !== null); } } |
︙ | ︙ | |||
529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 | let lEntry = []; for (let aRes of this.oIBDAWG.select()) { lEntry.push(aRes); } oLexiconTable.fill(lEntry); this.setDictData(this.oIBDAWG.nEntry, this.oIBDAWG.sDate); }, import: function () { let xInput = document.getElementById("import_input"); let xFile = xInput.files[0]; let xURL = URL.createObjectURL(xFile); let sJSON = helpers.loadFile(xURL); if (sJSON) { try { let oJSON = JSON.parse(sJSON); | > > > > > < > | | 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 | let lEntry = []; for (let aRes of this.oIBDAWG.select()) { lEntry.push(aRes); } oLexiconTable.fill(lEntry); this.setDictData(this.oIBDAWG.nEntry, this.oIBDAWG.sDate); }, save: function (oJSON) { browser.storage.local.set({ "oPersonalDictionary": oJSON }); browser.runtime.sendMessage({ sCommand: "setDictionary", dParam: {sDictionary: "personal", oDict: oJSON}, dInfo: {} }); }, import: function () { let xInput = document.getElementById("import_input"); let xFile = xInput.files[0]; let xURL = URL.createObjectURL(xFile); let sJSON = helpers.loadFile(xURL); if (sJSON) { try { let oJSON = JSON.parse(sJSON); this.__load(oJSON); this.save(oJSON); } catch (e) { console.error(e); this.setDictData(0, "#Erreur. Voir la console."); return; } } else { this.setDictData(0, "[néant]"); this.save(null); } }, setDictData: function (nEntries, sDate) { document.getElementById("dic_num_entries").textContent = nEntries; document.getElementById("dic_save_date").textContent = sDate; if (nEntries == 0) { |
︙ | ︙ | |||
574 575 576 577 578 579 580 | build: function () { let xProgressNode = document.getElementById("wait_progress"); let lEntry = oLexiconTable.getEntries(); if (lEntry.length > 0) { let oDAWG = new DAWG(lEntry, "S", "fr", "Français", "Dictionnaire personnel", xProgressNode); let oJSON = oDAWG.createBinaryJSON(1); | | < < < > > | 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 | build: function () { let xProgressNode = document.getElementById("wait_progress"); let lEntry = oLexiconTable.getEntries(); if (lEntry.length > 0) { let oDAWG = new DAWG(lEntry, "S", "fr", "Français", "Dictionnaire personnel", xProgressNode); let oJSON = oDAWG.createBinaryJSON(1); this.save(oJSON); this.oIBDAWG = new IBDAWG(oJSON); this.setDictData(this.oIBDAWG.nEntry, this.oIBDAWG.sDate); } else { this.setDictData(0, "[néant]"); this.save(null); } hideElement("save_button"); }, export: function () { let xBlob = new Blob([ JSON.stringify(this.oIBDAWG.getJSON()) ], {type: 'application/json'}); let sURL = URL.createObjectURL(xBlob); browser.downloads.download({ filename: "fr.personal.json", url: sURL, saveAs: true }); } |
︙ | ︙ |
Modified make.py from [bd0e45e8db] to [1dca0ff7aa].
︙ | ︙ | |||
459 460 461 462 463 464 465 | os.system(r'web-ext lint -o text') if xArgs.firefox: # Firefox Developper edition spfFirefox = dVars['win_fx_dev_path'] if platform.system() == "Windows" else dVars['linux_fx_dev_path'] else: # Firefox Nightly edition spfFirefox = dVars['win_fx_nightly_path'] if platform.system() == "Windows" else dVars['linux_fx_nightly_path'] | | > > | 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 | os.system(r'web-ext lint -o text') if xArgs.firefox: # Firefox Developper edition spfFirefox = dVars['win_fx_dev_path'] if platform.system() == "Windows" else dVars['linux_fx_dev_path'] else: # Firefox Nightly edition spfFirefox = dVars['win_fx_nightly_path'] if platform.system() == "Windows" else dVars['linux_fx_nightly_path'] #os.system(r'web-ext run --firefox="' + spfFirefox + '" --browser-console --firefox-profile=debug') # https://github.com/mozilla/web-ext/issues/932 os.system(r'web-ext run --firefox="' + spfFirefox + r'" --browser-console --firefox-profile=C:\Users\EAK\AppData\Roaming\Mozilla\Firefox\Profiles\e26559tw.debug --keep-profile-changes') # Thunderbird if xArgs.thunderbird: os.system("thunderbird -jsconsole -P debug") else: print("Folder not found: gc_lang/"+sLang) |
︙ | ︙ |